Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing branch in show_signature_annotations #362

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

machow
Copy link
Owner

@machow machow commented Aug 27, 2024

This PR addresses #361 by adding a missing branch, when rendering annotations. (TODO: add a test)

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (4739a4e) to head (9bf1ec1).
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   88.46%   88.65%   +0.19%     
==========================================
  Files          37       37              
  Lines        2931     2954      +23     
==========================================
+ Hits         2593     2619      +26     
+ Misses        338      335       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow machow merged commit 62759f0 into main Oct 10, 2024
6 checks passed
@machow machow deleted the fix-ref-error branch October 10, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants