Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix sidebar preview and collapse #379

Merged
merged 3 commits into from
Nov 8, 2024
Merged

docs: fix sidebar preview and collapse #379

merged 3 commits into from
Nov 8, 2024

Conversation

machow
Copy link
Owner

@machow machow commented Nov 4, 2024

This PR fixes the preview of the sidebar yaml on the sidebar guide page (previously the raw include directive appeared)

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (334bdc1) to head (d7c3756).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files          37       37           
  Lines        3004     3004           
=======================================
  Hits         2667     2667           
  Misses        337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Owner Author

machow commented Nov 8, 2024

Alright, for some reason the include shortcode can cause quarto add to fail 🤷🏼. Moving quarto add to just before rendering fixed...

@machow machow merged commit 5fa28ec into main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants