feature(ec2): Add parameters for storage & SSH #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomimatichin
added a commit
to valencesec/ec2-github-runner
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new features.
First is the
key-name. This is mapped to the Key Pair parameter of the EC2 instance. The reason for adding this is so that a user of the workflow can SSH into the instance to debug the runner.Second is the storage configuration. The default size of a volume in EC2 is 8GiB. Large projects with heavy dependencies can exceed this limit during build. This parameter will allow the user of the workflow to increase the storage of the EC2 instance. If the mountpath is set to the same as the default mountpath for the instance that's being used, the instance will just configure one volume with the size specified.