Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allegro.pl: Blokowanie ofert sponsorowanych #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jstasiak
Copy link

No description provided.

Copy link

@stpoa stpoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fajnie by było to dodać

@krystian3w
Copy link

Jest od roku bez "credits" / "co-authored by":

b474918 b474918#diff-c24ba8b8fd9f11b394de3dc3ea5fb548de75045e1c26fb63526cc6ef1aff7ca7R57

allegro.pl##article[data-analytics-view-label="showSponsoredItems"]
allegro.pl##article[data-analytics-view-label="showSponsoredItems"]

vs
allegro.pl##[data-analytics-view-label="showSponsoredItems"]

Raczej usuwanie article nie przyblokuje nowego wycieku jak w rok czasu Allegro nie przeniosło tego w losowy div/section/aside/span/li.

Copy link

@krystian3w krystian3w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To raczej załatwiło sprawę: b474918#diff-c24ba8b8fd9f11b394de3dc3ea5fb548de75045e1c26fb63526cc6ef1aff7ca7R57

PR wymaga przebudowania commitów z racji mocnego odświeżenia w 2021 jak ktoś znajdzie wyciek z użyciem innego tagu niż <article>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants