Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing attribute on vocabularies #8

Open
jonthegeek opened this issue Aug 23, 2021 · 2 comments
Open

Indexing attribute on vocabularies #8

jonthegeek opened this issue Aug 23, 2021 · 2 comments

Comments

@jonthegeek
Copy link
Member

Pre-trained models use 1-indexed vocabularies, but {torch} uses 0-indexed. Let's tag our vocabs so we can use those tags when they exist.

@jonthegeek jonthegeek mentioned this issue Aug 23, 2021
Merged
16 tasks
@jonathanbratt
Copy link
Contributor

Other way around: {torch} uses 1-indexing, while almost everyone else uses 0-indexing for the ids. :)

@jonthegeek
Copy link
Member Author

Er duh yes that's what I meant to type! Off-by-one errors strike my post about off-by-one errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants