data

[jonthegeek]

Author:

Common Mistakes to Catch Fast:

• Did you increment the version number?
• Did you re-build and document the package at the very end to make sure all changes were picked up?
• GP: Test coverage is very low on this, but I'm not fixing in this PR.

Tests:

• Do you have tests for all of the corner cases you can think of?

Documentation:

• Are all functions documented, including arguments and return values?
• Is there at least one example in the documentation of each exported function?
• README should really be updated in the next PR, but I focused on the vignette here.

Code Quality:

• Are all parameters validated?
• Is the parameter that's most likely to be piped into this function the first parameter?
• Are all internal functions prepended with '.'?
• Did you deal with all hacky things that you meant to address before PRing?

Reviewer:

Housekeeping:

• Did you review the author checklist (especially things in bold)?

Documentation:

• Can you understand what this feature is supposed to do from its help?
• Does the example seem like a typical use case?

Code Quality:

• Can you easily determine what each section of code does?

Tests:

• Can you build the package with your personal Rstudio setup?
• Do the tests pass for you?
• Can you think of any missing tests?

[jonathanbratt]

Some of the comments are just things to think about later, but there are a couple things we might want to change now. Overall, this is much cleaner than it was! :)