Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faad2: update cmake patch #21300

Merged

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Closes: https://trac.macports.org/ticket/68663

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 3.2.6 10M2518

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

aeiouaeiouaeiouaeiouaeiouaeiou commented Nov 9, 2023

@ryandesign all upstream changes are summarized and it looks like revbump of dependent ports is not needed as it now reports the correct version.
@RobK88 does this PR now fix the +universal build on your machine?

@RobK88
Copy link
Contributor

RobK88 commented Nov 9, 2023

@ryandesign @aeiouaeiouaeiouaeiouaeiouaeiou Yes, the patch fixed the problem building the +universal variant on my Mac running High Sierra.

bash-3.2$ sudo port clean faad2
--->  Cleaning faad2
bash-3.2$ 
bash-3.2$ sudo port upgrade faad2
--->  Computing dependencies for faad2
--->  Fetching distfiles for faad2
--->  Verifying checksums for faad2
--->  Extracting faad2
--->  Applying patches to faad2
--->  Configuring faad2
--->  Building faad2                                     
--->  Staging faad2 into destroot                        
--->  Installing faad2 @2.11.0_1+universal
--->  Cleaning faad2
--->  Deactivating faad2 @2.10.1_0+universal
--->  Cleaning faad2
--->  Activating faad2 @2.11.0_1+universal
--->  Cleaning faad2
--->  Scanning binaries for linking errors
--->  Found 1 broken file, matching files to ports       
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: gstreamer1-gst-plugins-bad @1.16.2+x11
Continue? [Y/n]: Y
etc
etc

bash-3.2$ port installed faad2
The following ports are currently installed:
  faad2 @2.10.1_0+universal
  faad2 @2.11.0_1+universal (active)

@herbygillot herbygillot merged commit 7b4f9aa into macports:master Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants