libcdio: fix crash reading CD TOC on macOS Ventura

[jmon12]

Remove the unnecessary byte added to the TOC buffer. See the upstream patch: https://git.savannah.gnu.org/cgit/libcdio.git/commit/?id=6f2426e8bf4dc5269ccbd9fbfa94340895f8be6e

Description

The test is rudimentary. I'm using the library only through freac which was crashing because of this bug, see for example this ticket. After the fix, it works.

This is my first contribution to macports, and I'd be happy to contribute more. Please feel free to add any "pedagogical comment"/recommendation.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 14.3.1 23D60 x86_64
Command Line Tools 15.1.0.0.1.1700200546

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[pmetzger]

Thanks for the contribution! A very small issue you might want to take care of.

[reneeotten]

sorry, one more change needed and then I'll merge. You will need to use "patchfiles-append", otherwise you will remove the patchfile added a few lines above.

[pmetzger]

Indeed! Good catch!

[jmon12]

Oh crap I'm sorry. I edit right away.

[chrstphrchvz]

This change requires a rebuild, so the revision should be incremented, correct?

[reneeotten]

This change requires a rebuild, so the revision should be incremented, correct?

Indeed!

[jmon12]

@chrstphrchvz Sorry for the beginner question, but what revision number should I increment? I don't see anything else than the libcdio version in the Portfile.

[chrstphrchvz]

@chrstphrchvz Sorry for the beginner question, but what revision number should I increment? I don't see anything else than the libcdio version in the Portfile.

--- a/devel/libcdio/Portfile
+++ b/devel/libcdio/Portfile
@@ -4,6 +4,7 @@ PortSystem          1.0
 
 name                libcdio
 version             2.1.0
+revision            1
 
 categories          devel
 license             GPL-3+

There is no revision 0 already in this port because it is optional and the libcdio port has not been updated in a while, but going forward the guide now recommends that ports specify revision 0 rather than omit it: https://guide.macports.org/chunked/reference.html#reference.keywords

[reneeotten]

@jmon12 please make the requested changes so that we can merge this PR

[jmon12]

OK, I just added the multiple changes requests and tested with port test libcdio:

• Increment the revision of the Portfile
• Remove the MacOS platform check
• Use patchfiles-append instead of patchfiles

I hope everything is fine now. I'm sorry for the late answer/action.