update opam Portfile: add dependency on gpatch #24197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the opam package repository can silently fail when using macos patch whenever files are removed upstream. As of opam 2.1.6 there is a warning on install to manually install gpatch to avoid any possible issue and the corruption of the local switches. See also ocaml/opam-repository#25961 This commit adds a dependency to gpatch to prevent any issue and avoid unnecessary manual intervention. Signed-off-by: Marcello Seri <[email protected]>
|
Notifying maintainers: |
macportsbot
added
type: enhancement
type: update
maintainer: open
reneeotten
requested changes
May 30, 2024
|
Thanks, I had missed that |
|
The two commits in this PR should have been squashed into one, for example by using the "Squash and merge" button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the opam package repository can silently fail when using macos patch whenever files are removed upstream. As of opam 2.1.6 there is a warning on install to
manually install gpatch to avoid any possible issue and the corruption of the local switches. See also ocaml/opam-repository#25961
This commit adds a dependency to gpatch to prevent any issue and avoid unnecessary manual intervention.
Type(s)
Tested on
macOS 14.5 23F79 arm64
Command Line Tools 15.3.0.0.1.1708646388
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?