Change watch maintainer

[stuartwesterman]

Description

Change mainter for unmaintained port sysutils/watch.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 14.5
Xcode 15.4

Verification

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint --nitpick?
• tested basic functionality of all binary files?

[reneeotten]

thanks for your interest in contributing to MacPorts @stuartwesterman ! Typically, someones first PR or contribution wouldn't be to become maintainer of a port, which is in fact not needed to contribute as anyone can submit a PR. Is there a specific reason why you'd like to become the maintainer of the watch port?

For starters, the port is outdated so why not submit a PR to update the port to the latest upstream version, that contribution can be done without being the port maintainer. In doing so you can become familiar with working with MacPorts and the policies, procedures and get ready to become a port maintainer.

Having said that: if you would like to become a maintainer then I would recommend you do the update at the same time.

[stuartwesterman]

Understood! I'll work on updating it and file a new PR. Thank you!

[reneeotten]

please keep this PR open and push changes here, no need to close/open a new one.

[reneeotten]

@stuartwesterman are you going to wrap this up? If not, I am going to close the PR.

[stuartwesterman]

I'm a bit stuck. It uses the gitlab port group for procps-ng. I tried compiling out 4.0.3 and 4.0.4 (currently watch is 4.0.0), and tried to update the patches while keeping the original semantic intent (libtoolize -> glibtoolize, etc), but I'm still missing something. Let me take a look this weekend, and if I still don't have it, I'll update here asking to close.

[stuartwesterman]

Figured it out. They (procps-ng) reorganized their directory structure. The make target is now make src/watch instead of just make watch . Moreover, they put the watch manpages in man/watch.1 instead of the top level project directory.

Here is some info:

m@im:~/workspace/code/macports-ports/sysutils/watch$ port info watch
watch @4.0.4_1 (sysutils)
Variants:             universal

Description:          watch is like top for arbitrary commands. It runs command repeatedly, displaying its output (the first screen full). This allows you to watch the program output change over time. This is part of the linux procps package.
Homepage:             https://gitlab.com/procps-ng/procps

Build Dependencies:   autoconf, automake, gettext, libtool, pkgconfig
Library Dependencies: ncurses
Platforms:            darwin
License:              GPL-2
Maintainers:          Email: [email protected], GitHub: stuartwesterman
                      Policy: openmaintainer
m@im:~/workspace/code/macports-ports/sysutils/watch$ watch --version
watch from procps-ng 4.0.4
m@im:~/workspace/code/macports-ports/sysutils/watch$ arch
arm64
m@im:~/workspace/code/macports-ports/sysutils/watch$ sw_vers
ProductName:		macOS
ProductVersion:		14.6.1
BuildVersion:		23G93
m@im:~/workspace/code/macports-ports/sysutils/watch$ uname -a
Darwin im.attlocal.net 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:21 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T8103 arm64
m@im:~/workspace/code/macports-ports/sysutils/watch$

Although, that portfile version 4.0.4_1 looks funny. Did I mess something up with @@VERSION@@, in the configure patch?

[stuartwesterman]

Oh. I see that _1 comes from the revision number in the Portfile. Not sure what to do there. Should I reset it to zero? Is it okay as _1 ?

[herbygillot]

Thank you for volunteering for watch.

Oh. I see that _1 comes from the revision number in the Portfile. Not sure what to do there. Should I reset it to zero? Is it okay as _1 ?

The revision field should reset to zero when the version gets updated.

revision is used to signify an update to a port in a situation where a change is being made to it that doesn't change the version. If it's at 1, then that means changes were made to it after it was updated to 4.0.0. Now that you are updating it to 4.0.4, revision should reset back to 0.

[stuartwesterman]

Thanks! I reset the revision number back to 0. port info watch looks good now.

[herbygillot]

OK. Going forward, PRs should have a single commit in <portname>: <description> format, so all the changes for this PR for example would have been a single commit whose description would have been watch: update to 4.0.4. I've gone ahead and squashed all the commits in this submission into a single commit in 99e9555

...but that's the expected format in general. If you have a PR open and are adding changes and fixes in response to comments, you would continue to amend and squash your new updates back into the same commit.

You can read more in the Commit Message Guidelines.