stylua: Enable more Lua version formatting #25450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, stylua is built with support for Lua 5.1 only, but can be built to support Lua 5.1 through Lua 5.4 and Luau. This only requires adding `luau` and `lua54` to the default features, `editorconfig` and `wasm-bindgen`. `lua54` implies `lua52` and `lua53`. I was able to format a Lua 5.4 file that was not previously formattable with the existing feature set.
|
Notifying maintainers: |
macportsbot
added
type: enhancement
maintainer: open
judaew
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, stylua is built with support for Lua 5.1 only, but can be built to support Lua 5.1 through Lua 5.4 and Luau. This only requires adding
luauandlua54to the default features,editorconfigandwasm-bindgen.lua54implieslua52andlua53.I was able to format a Lua 5.4 file that was not previously formattable with the existing feature set.
Type(s)
Tested on
macOS 14.6.1 23G93 arm64 Xcode 15.4 15F31d
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?