Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofetch: support MacPorts on non-Darwin systems #25458

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Description

Add support for MacPorts packages outside of MacOS.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

PinIx 2.1 / riscv64

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@rangeles for port neofetch.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Aug 25, 2024
@barracuda156
Copy link
Contributor Author

image

@rangeles
Copy link
Contributor

Hi, I'd like to decline this pull request. I'm not interested in adding patches on top of neofetch. I would say to please upstream your patches to the origin. However, I know this is not possible since the original project is now EOL. In other words, neofetch is frozen as is. If you'd like to get this patch in, I suggest making a fork of neofetch with your patches and maintaining your own port.

@barracuda156
Copy link
Contributor Author

@rangeles Hmm, I do not really get this, since the change is literally a copy of a single line of already existing neofetch code (same what works on macOS), it is not something invented by me, but this is your port…

@barracuda156
Copy link
Contributor Author

@dylanaraps Could it be possible to merge this to your repo?

@barracuda156
Copy link
Contributor Author

Maintainer not interested in fixing this, upstream does not respond. Closing.

@barracuda156 barracuda156 deleted the neofetch branch December 14, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

3 participants