Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyfetch: support host info for PowerPC Macs and MacPorts on Linux/BSD #25500

Merged
merged 2 commits into from
Aug 30, 2024
Merged

hyfetch: support host info for PowerPC Macs and MacPorts on Linux/BSD #25500

merged 2 commits into from
Aug 30, 2024

Conversation

barracuda156
Copy link
Contributor

Description

See commits

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@TheRealKeto for port hyfetch.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Aug 28, 2024
@barracuda156
Copy link
Contributor Author

hyfetch

@TheRealKeto
Copy link
Contributor

TheRealKeto commented Aug 28, 2024 •
edited
Loading

@barracuda156 Would you mind changing the maintainers field to match my Github handle? The field is case-sensitive (and I initially didn't know this) which creates an issue that's become a remnant of when I started opening submissions.

Otherwise, I'm fine with the changes and everything looks good!

@barracuda156
Copy link
Contributor Author

@TheRealKeto Fixed

TheRealKeto
TheRealKeto approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@TheRealKeto TheRealKeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's wait for the CI to finish before asking someone to merge. Thanks again!

@pmetzger pmetzger merged commit bd7b4b1 into macports:master Aug 30, 2024
3 checks passed
@barracuda156 barracuda156 deleted the hyfetch branch August 30, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealKeto TheRealKeto TheRealKeto approved these changes

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barracuda156 @macportsbot @TheRealKeto @pmetzger