Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more typos #14

Merged
merged 9 commits into from
Oct 17, 2021
Merged

Fix more typos #14

merged 9 commits into from
Oct 17, 2021

Conversation

Mo-Gul
Copy link
Contributor

@Mo-Gul Mo-Gul commented Oct 15, 2021

I also added some TODO markers and corresponding <-- {x} markers where I need your input how to deal with that.

Copy link
Contributor

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates - the README.md changes could have been gone in another PR. I think, this PR is blocked by the answer to {2}, but it is also OK for me to just merge this PR (after the MAPI update) to keep things going. -- I do not remember anything about szText.

@@ -41,6 +42,7 @@ Private Const REG_GROUP_FIRSTNAMES As String = "Firstnames" 'stores replacements
'*** Feature QuoteColorizer ***
'--------------------------------------------------------
Private Const DEFAULT_USE_COLORIZER As Boolean = False
'TODO: add note where to get the DLL from. I couldn't find it on my system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the README.md is a good place.

Get `maprtf.dll` from `mapirtf.exe`.
You can get this file from [KB 172038](https://web.archive.org/web/20140112002906/http://support.microsoft.com/kb/172038).
Deep link: <http://download.microsoft.com/download/mapi/utility/11/w9xnt4/en-us/mapirtf.exe>.
Extract it with 7zip and copy `mapirtf.dll` to `C:\Windows\System32`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that. But downloading and "installing" it gives me runtime error 48: file not found: mapirtf.dll. Can you confirm that this works on your side? (That would indicate that this is a "problem" on my machine.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened issue #18. I had issue 53, but could solve it - now, my Outlook 2019 crashes.

@koppor
Copy link
Contributor

koppor commented Oct 17, 2021

I merge to keep things going.

@koppor koppor marked this pull request as ready for review October 17, 2021 20:53
@koppor koppor merged commit 34ebb77 into macros4outlook:main Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants