refactor: removed job id from panic message, was redundant

madara-alliance · Nov 9, 2024 · c17d7a9 · c17d7a9
1 parent c470f82
commit c17d7a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/crates/orchestrator/src/jobs/mod.rs b/crates/orchestrator/src/jobs/mod.rs
@@ -252,7 +252,7 @@ pub async fn process_job(id: Uuid, config: Arc<Config>) -> Result<(), JobError>
             return move_job_to_failed(
                 &job,
                 config.clone(),
-                format!("Job handler panicked in job with id: {} and panic message: {}", id, panic_msg),
+                format!("Job handler panicked with message: {}", panic_msg),
             )
             .await;
         }

diff --git a/crates/orchestrator/src/tests/jobs/mod.rs b/crates/orchestrator/src/tests/jobs/mod.rs
@@ -231,13 +231,11 @@ async fn process_job_handles_panic() {
     let job_in_db = database_client.get_job_by_id(job_item.id).await.unwrap().unwrap();
     assert_eq!(job_in_db.status, JobStatus::Failed);
     assert!(
-        job_in_db.metadata.get(JOB_METADATA_FAILURE_REASON).unwrap().contains(
-            format!(
-                "Job handler panicked in job with id: {} and panic message: Simulated panic in process_job",
-                job_item.id
-            )
-            .as_str()
-        )
+        job_in_db
+            .metadata
+            .get(JOB_METADATA_FAILURE_REASON)
+            .unwrap()
+            .contains("Job handler panicked with message: Simulated panic in process_job")
     );
 }