-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/test aws #186
Fix/test aws #186
Conversation
118488d
to
1d6d398
Compare
1d6d398
to
64a7d28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things that I noticed:
- Shall we add more informational statements while setting up the cloud? Currently it shows setting up [x] and then setup of [x] complete?
- While creating the jobs, we are not saving it in the metrics but we are saving it if the job creation fails. I understand we have metrics on successful completion of the job but shall we have it for creation of the job as well?
- Currently in our cloud setup if something breaks in between we have start again, and this would create additional resources on the cloud. I understand this might not be the priority as of now, just putting it out here.
PS: I am not sure about either of these, just putting it out here
1 & 3. We can for sure, let's take up 1 and 3 together in a separate PR, here's the issue to track this. 2: we are taking metrics on successful as well as failed creation on jobs, |
This PR includes fixes for :