Expect removed from various places #197
Open
+99
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemankv
reviewed
Dec 27, 2024
| .bucket(bucket_name) | ||
| .send() | ||
| .await | ||
| .context(format!("Failed to create bucket: {} in us-east-1", bucket_name))?; |
There was a problem hiding this comment.
Can we try to change this
if self.bucket_location_constraint.as_str() == "us-east-1" {
and compare the enums provided by AWS.
Accordingly change the context to not hardcode us-east-1
Note: I tried doing this in a recent PR but the code was failing after
maybe you can try and this time it might work ?
WDYT @Mohiiit ?
| @@ -231,7 +231,8 @@ fn parse_worker_message(message: &Delivery) -> Result<Option<WorkerTriggerMessag | |||
| .borrow_payload() | |||
| .ok_or_else(|| ConsumptionError::Other(OtherError::from("Empty payload".to_string())))?; | |||
| let message_string = String::from_utf8_lossy(payload).to_string().trim_matches('\"').to_string(); | |||
| let trigger_type = WorkerTriggerType::from_str(message_string.as_str()).expect("trigger type unwrapping failed"); | |||
| let trigger_type = WorkerTriggerType::from_str(message_string.as_str()) | |||
| .map_err(|e| ConsumptionError::Other(OtherError::from(e)))?; | |||
There was a problem hiding this comment.
Let's add a wrap_err here as well,
seems like a good practice to follow
WDYT @Mohiiit ?
| @@ -85,8 +85,7 @@ impl AtlanticClient { | |||
| ) | |||
| .send() | |||
| .await | |||
| .map_err(AtlanticError::AddJobFailure) | |||
| .expect("Failed to add job"); | |||
| .map_err(AtlanticError::AddJobFailure)?; | |||
There was a problem hiding this comment.
Same, can add wrap_err here
WDYT on adding wrap_err throughout the code @Mohiiit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed expect and added wrap for the error