Skip to content

Commit

Permalink
chore: remove redundant dead_code attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
jbcaron committed Jan 5, 2025
1 parent 922d7a8 commit 753dfc3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next release

- chore: remove redundant dead_code attribute
- chore: Move crates under a madara subdir
- chore(nix): resolve flake and direnv compatibility issues
- fix: Gateway path fix
Expand Down
11 changes: 5 additions & 6 deletions crates/madara/client/eth/src/l1_messaging.rs
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ mod l1_messaging_tests {
use self::DummyContract::DummyContractInstance;

struct TestRunner {
#[allow(dead_code)]
anvil: AnvilInstance, // Not used but needs to stay in scope otherwise it will be dropped
_anvil: AnvilInstance, // Not used but needs to stay in scope otherwise it will be dropped
chain_config: Arc<ChainConfig>,
db_service: Arc<DatabaseService>,
dummy_contract: DummyContractInstance<Http<Client>, RootProvider<Http<Client>>>,
Expand Down Expand Up @@ -381,7 +380,7 @@ mod l1_messaging_tests {
l1_block_metrics: l1_block_metrics.clone(),
};

TestRunner { anvil, chain_config, db_service: db, dummy_contract: contract, eth_client, mempool }
TestRunner { _anvil: anvil, chain_config, db_service: db, dummy_contract: contract, eth_client, mempool }
}

/// Test the basic workflow of l1 -> l2 messaging
Expand All @@ -400,7 +399,7 @@ mod l1_messaging_tests {
#[traced_test]
#[tokio::test]
async fn e2e_test_basic_workflow(#[future] setup_test_env: TestRunner) {
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, anvil: _anvil, mempool } =
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, mempool, .. } =
setup_test_env.await;

// Start worker
Expand Down Expand Up @@ -461,7 +460,7 @@ mod l1_messaging_tests {
#[traced_test]
#[tokio::test]
async fn e2e_test_already_processed_event(#[future] setup_test_env: TestRunner) {
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, anvil: _anvil, mempool } =
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, mempool, .. } =
setup_test_env.await;

// Start worker
Expand Down Expand Up @@ -517,7 +516,7 @@ mod l1_messaging_tests {
#[traced_test]
#[tokio::test]
async fn e2e_test_message_canceled(#[future] setup_test_env: TestRunner) {
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, anvil: _anvil, mempool } =
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, mempool, .. } =
setup_test_env.await;

// Start worker
Expand Down

0 comments on commit 753dfc3

Please sign in to comment.