-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for declare v0, l1 handler and l1->l2 messages #321
Merged
+1,546
−1,294
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
789f457
feat: declare v0 working
d448b65
debug: debuging declare v0
b842ae6
main merged
3da2f1a
adding comments for debugging
2938bef
debugging with bootstraper
b8c554c
making l1 handler execute in the mempool
62e174f
feat: refactored Mempool to accept L1Handler txn
4c16c8e
fixing test for l1 message and mempool inner
7f31dde
merged with main
50dcc7a
formatting and linting
f9650f5
formatting and changelog
334c258
comments removed
7c98ebd
main merged
bc05e4f
Merge branch 'main' into feat/declare_v0
Trantorian1 7c63396
validation added for txns
1485eca
feat: main merged
c857b79
resolving issues
8e510c9
refactor: declare v0 refactored with different rpc namespace
0ca66af
main merged
501eaf8
merged with upstream
21d12f5
merged with main
2ad4d19
msgL2 hash added
fc16ff3
formatting and linting
2209885
tests added for proc macros, error added for empty namespace, removed…
ed5b6c0
fixing comments
eaf5411
main merged
f21baad
fix: build fix
77038a2
feat: added error when namespace is not present or method is not pres…
7669670
feat: de/serialize tests added for BroadcastedDeclareTransactionV0, c…
51054f8
fix: state diff special address should have current_block - 10 block …
b7a2a3e
feat: updating filter of l1 message to check between last and finaliz…
8ed287c
linting and formatting
638c645
refactor: reverting the event filter in l1 messaging
859e50c
Merge branch 'main' into feat/declare_v0
Mohiiit 2fa3b46
extra clones removed
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
formatting and linting
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a
at the bottom of the file that you should try commenting to see if the proptest passes locally
(don't commit it though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, but please add a comment saying that the handling of nonces on l1 handler txs is wrong
Also, when I get to fixing it, what tests should I run to see that I did not break l1 messages in the process?