fix(db): max rocksdb LOG files count and size and add more memory metrics #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiyro
approved these changes
Oct 15, 2024
apoorvsadana
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
rocksdb's LOG file is unbounded and takes wayyyy too much space in production
What is the new behavior?
limit the number of rocksdb LOG files, and their size.
Set the rocksdb level to WARN, which will print a summary of all column stats (~100Ko) at startup only, whereas the INFO level will print it very regularily.
Plus, add a few more memtable metrics to prometheus endpoint.
Does this introduce a breaking change?
No