-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added special address with block number and block hash #347
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e2e2ea1
feat: added special address with block number and block hash
91e0837
fix: changelog and clippy
a067c6a
comments resolved
d583d76
fmt: removing double error logs
f3ef556
Merge branch 'main' into feat/special-address
Trantorian1 0370eab
Merge branch 'main' into feat/special-address
Trantorian1 7381840
get storage at updated with special address case
f08dc89
refactor: get storage at updated for rpc and state reader
27ed156
refactor: taking hash of madara binary while caching it
38e7c75
refactor: js
04353f2
refactor: js workflow updated
e546705
fix: fixing madara binary cache issue in workflow
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -405,9 +405,34 @@ impl<Mempool: MempoolProvider> BlockProductionTask<Mempool> { | |
|
||
// Complete the block with full bouncer capacity. | ||
let start_time = Instant::now(); | ||
let (new_state_diff, _n_executed) = | ||
let (mut new_state_diff, _n_executed) = | ||
self.continue_block(self.backend.chain_config().bouncer_config.block_max_capacity)?; | ||
|
||
// SNOS requirement: For blocks >= 10, the hash of the block 10 blocks prior | ||
// at address 0x1 with the block number as the key | ||
if block_n >= 10 { | ||
let prev_block_number = block_n - 10; | ||
match self.backend.get_block_hash(&BlockId::Number(prev_block_number)) { | ||
Ok(Some(prev_block_hash)) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's add a comment There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
let address = Felt::ONE; | ||
new_state_diff.storage_diffs.push(ContractStorageDiffItem { | ||
address, | ||
storage_entries: vec![StorageEntry { key: Felt::from(block_n), value: prev_block_hash }], | ||
}); | ||
} | ||
Ok(None) => { | ||
return Err(Error::Unexpected( | ||
format!("No block hash found for block number {}", prev_block_number).into(), | ||
)); | ||
} | ||
Err(e) => { | ||
return Err(Error::Unexpected( | ||
format!("Error fetching block hash for block {}: {:?}", prev_block_number, e).into(), | ||
)); | ||
} | ||
} | ||
} | ||
|
||
// Convert the pending block to a closed block and save to db. | ||
|
||
let parent_block_hash = Felt::ZERO; // temp parent block hash | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this match can be simplified to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved