fix(gateway): path #429
Closed
fix(gateway): path #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you fix CI on that? Adding changelog should do the job. |
Uacias
force-pushed
the
hotfix/gateway_router
branch
from
3dabd1b to
379a2fa
Compare
jbcaron
approved these changes
Dec 23, 2024
antiyro
approved these changes
Dec 23, 2024
|
close by #440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
The gateway_router function incorrectly matches paths for the
add_transactionendpoint. Requests to/gateway/add_transactionresult in a Not Found response because the matching logic does not handle paths correctly.Resolves: #NA
What is the new behavior?
gateway_routerfnDoes this introduce a breaking change?
No
Other information
Would also work using
req.uri().path().trim_start_matches('/'), butpathapproach is cleaner imho.