feat(db): add database version management system #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcaron
force-pushed
the
build/db-version
branch
from
b80d750 to
4ea1c36
Compare
jbcaron
changed the title
antiyro
approved these changes
Dec 18, 2024
jbcaron
force-pushed
the
build/db-version
branch
2 times, most recently
from
2945ec5 to
4bd1826
Compare
jbcaron
force-pushed
the
build/db-version
branch
from
4bd1826 to
422acc5
Compare
Trantorian1
added
feature
jbcaron
force-pushed
the
build/db-version
branch
5 times, most recently
from
391b694 to
97ea3f1
Compare
jbcaron
force-pushed
the
build/db-version
branch
from
97ea3f1 to
be742e0
Compare
Trantorian1
approved these changes
Jan 3, 2025
Comment on lines
+11
to
+16
| //! current_version: 42 | ||
| //! versions: | ||
| //! - version: 42 | ||
| //! pr: 123 | ||
| //! - version: 41 | ||
| //! pr: 120 |
There was a problem hiding this comment.
Suggested change
| //! current_version: 42 | |
| //! versions: | |
| //! - version: 42 | |
| //! pr: 123 | |
| //! - version: 41 | |
| //! pr: 120 | |
| //! current_version: 69 | |
| //! versions: | |
| //! - version: 69 | |
| //! pr: 420 | |
| //! - version: 68 | |
| //! pr: 419 |
jbcaron
removed
the
research
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Currently there is no system to manage database version compatibility between binary releases. This can lead to data corruption or unexpected behavior when users upgrade their binary without migrating their database.
Resolves: #NA
What is the new behavior?
Key components added:
.db-versions.ymlfile to track version history with PR referencesFiles added/modified:
.db-versions.yml- Version tracking filescripts/update-db-version.sh- Version bump script.github/workflows/pull_request.yml- CI integration.github/workflows/db-version.yml- CI integrationcrates/client/db/build.rs- Build-time version extractioncrates/client/db/src/db_version.rsRuntime version validation code.github/labels.yml- Added 'bump_db' labelDoes this introduce a breaking change?
No, this is a new feature that adds safety checks without modifying existing behavior. However, after this PR:
Other information
To use the new version system: