Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant dead_code attribute #433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: remove redundant dead_code attribute #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753dfc3
chore: remove redundant dead_code attribute
jbcaron Dec 18, 2024
edfebfc
Merge branch 'main' into chore/rm-dead_code-attribute
jbcaron Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/madara/client/eth/src/l1_messaging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ mod l1_messaging_tests {
use self::DummyContract::DummyContractInstance;

struct TestRunner {
#[allow(dead_code)]
anvil: AnvilInstance, // Not used but needs to stay in scope otherwise it will be dropped
_anvil: AnvilInstance, // Not used but needs to stay in scope otherwise it will be dropped
chain_config: Arc<ChainConfig>,
db_service: Arc<DatabaseService>,
dummy_contract: DummyContractInstance<Http<Client>, RootProvider<Http<Client>>>,
Expand Down Expand Up @@ -381,7 +380,7 @@ mod l1_messaging_tests {
l1_block_metrics: l1_block_metrics.clone(),
};

TestRunner { anvil, chain_config, db_service: db, dummy_contract: contract, eth_client, mempool }
TestRunner { _anvil: anvil, chain_config, db_service: db, dummy_contract: contract, eth_client, mempool }
}

/// Test the basic workflow of l1 -> l2 messaging
Expand All @@ -400,7 +399,7 @@ mod l1_messaging_tests {
#[traced_test]
#[tokio::test]
async fn e2e_test_basic_workflow(#[future] setup_test_env: TestRunner) {
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, anvil: _anvil, mempool } =
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, mempool, .. } =
setup_test_env.await;

// Start worker
Expand Down Expand Up @@ -461,7 +460,7 @@ mod l1_messaging_tests {
#[traced_test]
#[tokio::test]
async fn e2e_test_already_processed_event(#[future] setup_test_env: TestRunner) {
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, anvil: _anvil, mempool } =
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, mempool, .. } =
setup_test_env.await;

// Start worker
Expand Down Expand Up @@ -517,7 +516,7 @@ mod l1_messaging_tests {
#[traced_test]
#[tokio::test]
async fn e2e_test_message_canceled(#[future] setup_test_env: TestRunner) {
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, anvil: _anvil, mempool } =
let TestRunner { chain_config, db_service: db, dummy_contract: contract, eth_client, mempool, .. } =
setup_test_env.await;

// Start worker
Expand Down
Loading