Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update configs #356

Merged
merged 23 commits into from
Aug 12, 2024
Merged

refactor: update configs #356

merged 23 commits into from
Aug 12, 2024

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Jul 26, 2024

PR Description

  • updated modules
  • updated some charts
  • set depends_on to fix the order of applying and deleting resources
  • fixed karpenter configuration after updating the module

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@mglotov mglotov requested a review from a team July 26, 2024 11:03
@mglotov mglotov changed the title Update configs refactor: update configs Jul 26, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

pip3 install --no-cache --upgrade pip setuptools wheel && \
if [ ! -e /usr/bin/pip ]; then ln -s pip3 /usr/bin/pip ; fi
RUN echo "**** install Python and pip ****" && \
apk add --update --no-cache python3 py3-pip py3-setuptools py3-wheel

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud

#Install additional packages and helm
RUN apk add --update --no-cache openssl git jq bash curl wget unzip ca-certificates && \
RUN echo "**** install additional packages and helm ****" && \
apk add --update --no-cache openssl git jq bash curl wget unzip ca-certificates && \

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud
pip3 install --no-cache --upgrade pip setuptools wheel && \
if [ ! -e /usr/bin/pip ]; then ln -s pip3 /usr/bin/pip ; fi
RUN echo "**** install Python and pip ****" && \
apk add --update --no-cache python3 py3-pip py3-setuptools py3-wheel

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud
@mglotov mglotov merged commit d8b659d into terragrunt Aug 12, 2024
6 of 11 checks passed
@mglotov mglotov deleted the update-configs branch August 12, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants