add option to not use references in yaml output #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix raise of UndefinedVariableError
Optionnal classes
Fix reclass parser to include OPT_IGNORE_CLASS_NOTFOUND
Pass defaults for ingore_class_notfound properly
Inventory query errors were raising exceptions due to a missed change of a value.contents() method to a class property
Allow to use '..' as a reference to higher level in class structure
usable yaml_git and mixed storage types
Added unit tests, removed some redundant code, removed parser from settings -- it was hardcoded, so no real reason to keep it there, amended logic for parser application: previosly only default sentinels were used in parser selection optimization, now a sentinel is picked from settings.
Settings code deduplicated.
Mostly minor changes to make code more compliant with proper coding style, also some repetitions are removed.
Reference sentinel was hardcoded in core, replaced it with proper counting of actual sentinels that are present in settings.
In the course of refactoring a bug was introduced which manifested itself in excessive constructions of parsers and considerable slowdown of reclass. This patch limits the number of parsers constructed.
More refactoring
Tests for full parser and simplified reference parser are added. The new tests simultaneously act as documentation for parsers. Also some mostly cosmetic changes are applied to parser building functions and Parser() class.
Change-Id: Id8fa33004bbf0e18d7e94c2da9a7d3120bf8a3c4
Tests for parsers are added
Change-Id: Id3e474a8bd77bb474ef1fcbc5df327f7b84db894
Fixes: salt-formulas#77 Signed-off-by: Alexandru Avadanii <[email protected]>
Fixed typo in settings definitions.
Fix a typo: Canot -> Cannot
…re_overwritten_missing_reference Fix ignore_overwritten_missing_reference default
added support for .yaml along with .yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to optionally stop yaml output from using references, as sometimes it's clearer to explicitly fill in references.
ie go from with reference output:
to filling in the references:
Current behaviour of outputting using references is retained as the default, with a command line argument ('-r' or '--no-refs') to not use references.