Add optional support to ignore classes that are not found #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge: this is not ready yet. |
|
Actually this is now ready to be reviewed. |
|
Bump :) |
|
I like the idea and can imaging the use-case - eg. include class that gets generated on demand (eg. by deploy tool) and can override some parameters. But it may be good to provide some logging (eg. "Inclusion of slass xyz skipped because it doesn't exist") to make debugging with this option enabled easier :-) |
|
Sure, what is the normal way to log messages in reclass? |
bbinet
pushed a commit
to bbinet/reclass
that referenced
this pull request
Apr 2, 2020
Fix a typo: Canot -> Cannot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to configure reclass so that it ignores possible missing classes.