Implement submit action #33
Conversation
WalkthroughThe changes bring in a new subparser for task submission, refactor task parsing to include submission links, and streamline test functions for efficiency. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![senior-dev-bot[bot]](https://avatars.githubusercontent.com/in/282840?s=60&v=4){kind=small}
moocfi_cses.py
Outdated
| import json | ||
| from urllib.parse import urljoin | ||
| from pathlib import Path | ||
| from time import sleep | ||
| from typing import AnyStr, Optional | ||
| from xml.etree.ElementTree import Element, tostring | ||
|
|
There was a problem hiding this comment.
CODE REVIEW
The changes introduce the sleep function from the time module. Ensure that using sleep in your code is necessary, as it can introduce delays that might not be desirable, especially in IO-bound or async applications. If its use is unavoidable for rate-limiting or similar purposes, consider alternatives like async sleep functionalities in asynchronous environments or other throttling mechanisms.
No further improvements or issues are noticeable based solely on the import statements. However, always consider the impact of adding new dependencies or modules on the application's performance and maintainability.
moocfi_cses.py
Outdated
| desc_div = desc_div_element if desc_div_element is not None else Element("div") | ||
| description = html2text(tostring(desc_div).decode("utf8")) | ||
| code = root.findtext(".//pre", "N/A") | ||
| submit_link_element = root.find('.//a[.="Submit"]') | ||
| submit_link = ( | ||
| submit_link_element.get("href", "N/A") | ||
| if submit_link_element is not None | ||
| else "N/A" | ||
| ) | ||
|
|
||
| submit_file = next( | ||
| iter( | ||
| [ |
There was a problem hiding this comment.
CODE REVIEW
The changes generally look good, but you could improve readability and consistency by adopting the same pattern as your initial condition with desc_div_element. Consider using a ternary operator immediately, making it concise and consistent with the existing code style.
submit_link_element = root.find('.//a[.="Submit"]')
submit_link = submit_link_element.get("href", "N/A") if submit_link_element is not None else "N/A"
moocfi_cses.py
Outdated
| parser_show.set_defaults(cmd="show") | ||
| parser_show.add_argument("task_id", help="Numerical task identifier") | ||
|
|
||
| # submit exercise solution subparser | ||
| parser_submit = subparsers.add_parser("submit", help="Submit an exercise solution") | ||
| parser_submit.set_defaults(cmd="submit") | ||
| parser_submit.add_argument("--filename", help="Filename of the solution to submit") | ||
| parser_submit.add_argument("task_id", help="Numerical task identifier") | ||
|
|
||
| return parser.parse_args(args) | ||
|
|
||
|
|
There was a problem hiding this comment.
CODE REVIEW
It's generally clean and modular. However, specifying the task_id as a positional argument in both subparsers could imply inconsistency if these actions (show and submit) fundamentally operate on tasks in different ways. If both actions require task_id similarly, it's alright. Otherwise, consider adding more explicit argument types for clarity, e.g., using type=int to enforce numerical IDs. Additionally, adding required=True to required arguments enhances usability.
Example:
parser_submit.add_argument("--filename", required=True, help="Filename of the solution to submit")
parser_submit.add_argument("task_id", type=int, help="Numerical task identifier")
moocfi_cses.py
Outdated
| id: str | ||
| name: str | ||
| state: TaskState | ||
| description: str = "N/A" | ||
| code: str = "N/A" | ||
| submit_file: str = "N/A" | ||
| description: Optional[str] = None | ||
| code: Optional[str] = None | ||
| submit_file: Optional[str] = None | ||
| submit_link: Optional[str] = None | ||
|
|
||
|
|
||
| def parse_task_list(html: AnyStr) -> list[Task]: |
There was a problem hiding this comment.
CODE REVIEW
The change from default string values to Optional[str] with defaults of None is a good approach for clarifying potentially unset values. However, it's essential to consider how this affects other parts of the code that may expect string values. For instance, if there are operations like string concatenation or formatting with these variables, those would now potentially raise exceptions if not checked for None.
# Original
description: str = "N/A"
# Updated
description: Optional[str] = NoneEnsure any function handling Task objects is prepared to handle these None values appropriately.
moocfi_cses.py
Outdated
| return link_data | ||
|
|
||
|
|
||
| def parse_form(html: AnyStr, xpath: str = ".//form") -> dict[str, str | None]: | ||
| def parse_form(html: AnyStr, xpath: str = ".//form") -> dict: | ||
| """Search for the first form in html and return dict with action and all other found inputs""" | ||
| form_element = htmlement.fromstring(html).find(xpath) | ||
| form_data = dict() |
There was a problem hiding this comment.
CODE REVIEW
It's generally good practice to be explicit about types in Python, especially with type hinting in Python 3. It improves code readability and helps with debugging and maintaining. The change here removes the specificity of the return type for parse_form, making it less informative. Consider keeping or even expanding the type hints for better clarity and utility.
Before:
def parse_form(html: AnyStr, xpath: str = ".//form") -> dict:After:
from typing import Union, Optional, Dict
def parse_form(html: AnyStr, xpath: str = ".//form") -> Dict[str, Optional[str]]:
moocfi_cses.py
Outdated
| description=description.strip(), | ||
| code=code, | ||
| submit_file=submit_file, | ||
| submit_link=submit_link, | ||
| ) | ||
|
|
||
| return task |
There was a problem hiding this comment.
CODE REVIEW
The code change looks concise, adding a submit_link parameter. Ensure that:
submit_linkis sanitized & validated (if it's user input).- Check if any default value or null handling is needed for
submit_link. - Update relevant function documentation or comments to include
submit_link.
Example for validation (assuming submit_link is a URL):
from urllib.parse import urlparse
def is_valid_url(url):
try:
result = urlparse(url)
return all([result.scheme, result.netloc])
except ValueError:
return False
if not is_valid_url(submit_link):
raise ValueError("Invalid submit link")
moocfi_cses.py
Outdated
| task = parse_task(html) | ||
| print_task(task) | ||
|
|
||
| if args.cmd == "submit": | ||
| html = session.http_request(urljoin(base_url, f"task/{args.task_id}")) | ||
| task = parse_task(html) | ||
| if not task.submit_file or task.submit_file == "N/A": | ||
| raise ValueError("No submission filename found") | ||
| if not task.submit_link or task.submit_link == "N/A": | ||
| raise ValueError("No submission link found") | ||
|
|
||
| submit_form_html = session.http_request(urljoin(base_url, task.submit_link)) | ||
| submit_form_data = parse_form(submit_form_html) | ||
| action = submit_form_data.pop("_action") | ||
|
|
||
| for key, value in submit_form_data.items(): | ||
| submit_form_data[key] = (None, value) | ||
| submit_form_data["file"] = (task.submit_file, open(task.submit_file, "rb")) | ||
| submit_form_data["lang"] = (None, "Python3") | ||
| submit_form_data["option"] = (None, "CPython3") | ||
|
|
||
| res = session.http_session.post( | ||
| urljoin(base_url, action), files=submit_form_data | ||
| ) | ||
| html = res.text | ||
| result_url = res.url | ||
| print("Waiting for test results.", end="") | ||
| while "Test report" not in html: | ||
| print(".", end="") | ||
| sleep(1) | ||
| html = session.http_request(result_url) | ||
|
|
||
| print() | ||
| root = htmlement.fromstring(html) | ||
| submit_status_element = root.find('.//td[.="Status:"]/..') or Element("td") | ||
| submit_status_span_element = submit_status_element.find("td/span") or Element( | ||
| "span" | ||
| ) | ||
| submit_status = submit_status_span_element.text or "" | ||
| submit_result_element = root.find('.//td[.="Result:"]/..') or Element("td") | ||
| submit_result_span_element = submit_result_element.find("td/span") or Element( | ||
| "span" | ||
| ) | ||
| submit_result = submit_result_span_element.text or "" | ||
|
|
||
| print(f"Submission status: {submit_status.lower()}") | ||
| print(f"Submission result: {submit_result.lower()}") | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
There was a problem hiding this comment.
CODE REVIEW
Consider abstracting the new functionality into separate functions to improve readability and maintainability. Additionally, verifying file existence before attempting to open it improves robustness. Use with statement for file handling to ensure proper closure of the file. Refrain from directly printing dots in a loop as it's not efficient for user feedback in all environments; consider logging or other progress indication methods.
Example adjustments:
- submit_form_data["file"] = (task.submit_file, open(task.submit_file, "rb"))
+ file_path = task.submit_file
+ if not os.path.exists(file_path):
+ raise FileNotFoundError(f"{file_path} does not exist")
+ with open(file_path, "rb") as file:
+ submit_form_data["file"] = (task.submit_file, file)
+ # Rest of file handlingSplit large blocks into functions:
+ if args.cmd == "submit":
+ submit_task(args, session)Refactoring this way enhances code structure, making it easier to manage and understand.
There was a problem hiding this comment.
@senior-dev-bot can you suggests some unit tests for this method?
moocfi_cses.py
Outdated
| print(f"\nSubmission file name: {task.submit_file}") | ||
|
|
||
|
|
||
| def submit_task(task_id: str, filename: str) -> None: | ||
| """submit file to the submit form or task_id""" | ||
| # NOTE: use parse_form | ||
| ... | ||
| # def submit_task(task_id: str, filename: str) -> None: | ||
| # """submit file to the submit form or task_id""" | ||
| # html = session.http_request(urljoin(base_url, f"task/{task_id}")) | ||
| # task = parse_task(html) | ||
| # answer = input("Do you want to submit this task? (y/n): ") | ||
| # if answer in ('y', 'Y'): | ||
| # with open(filename, 'r') as f: | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
CODE REVIEW
-
Comments on Code Removal: Commenting out
submit_taskwithout removing it or replacing it implies uncertainty about its necessity. If the function is obsolete, delete it. If its functionality is being replaced or updated, ensure the new or updated code is included and clearly documented.# Consider removing or properly replacing this with updated functionality. -
Incomplete Replacement Implementation: The snippet shows the start of a replacement for
submit_task, but it's incomplete and inactive due to being commented. If this is a work in progress, finish the implementation, including error handling, actual submission logic, and feedback to the user on success or failure.def submit_task(task_id: str, filename: str) -> None: """Submit file to the task.""" # Implementation goes here... # Ensure error handling, user feedback, and complete functionality.
-
Code Organization: Keep your code clean and organized. If
submit_taskis under modification, ensure it reflects the complete and final intent. Temporary or WIP code should be clearly marked or, preferably, kept out of the main branch until complete.# TODO: Complete this function before merging. -
Functionality and User Input: If replacing
submit_task, ensure you're including all necessary parts such as making the actual HTTP request to submit the task, handling potential errors, and validating the user's input more robustly.answer = input("Do you want to submit this task? (y/n): ").strip().lower() if answer == 'y': # Proceed with submission. else: # Handle 'no' response appropriately.
Remember, keeping your codebase clean and only merging complete, fully vetted features helps maintain overall code quality and reduces technical debt.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- moocfi_cses.py (8 hunks)
Additional comments not posted (6)
moocfi_cses.py (6)
9-9: Import statement forsleepis correctly added.
149-153: The new subparser for submitting tasks is correctly defined.
261-264: The changes to theTaskclass attributes are appropriate and align with the new functionality.
264-264: The addition of thesubmit_linkattribute is correctly implemented.
324-330: The enhancement to extractsubmit_linkin theparse_taskfunction is correctly implemented.
348-348: The update to display the submission file name in theprint_taskfunction is correctly implemented.
moocfi_cses.py
Outdated
| # def submit_task(task_id: str, filename: str) -> None: | ||
| # """submit file to the submit form or task_id""" | ||
| # html = session.http_request(urljoin(base_url, f"task/{task_id}")) | ||
| # task = parse_task(html) | ||
| # answer = input("Do you want to submit this task? (y/n): ") | ||
| # if answer in ('y', 'Y'): | ||
| # with open(filename, 'r') as f: |
There was a problem hiding this comment.
The submit_task function is commented out, and its logic is moved to the main function. Consider refactoring the submission logic into a separate function for better maintainability.
madeddie
force-pushed
the
27-implement-exercise-solution-submission-submit-subcommand
branch
from
ee40870
to
3e38a5a
Compare
|
moocfi_cses.py
Outdated
| # submit exercise solution subparser | ||
| parser_submit = subparsers.add_parser("submit", help="Submit an exercise solution") | ||
| parser_submit.set_defaults(cmd="submit") | ||
| parser_submit.add_argument("--filename", help="Filename of the solution to submit") | ||
| parser_submit.add_argument("task_id", help="Numerical task identifier") |
There was a problem hiding this comment.
Specify required=True for the --filename argument to enhance usability.
parser_submit.add_argument("--filename", required=True, help="Filename of the solution to submit")
moocfi_cses.py
Outdated
| @@ -221,7 +228,7 @@ def find_link(html: AnyStr, xpath: str) -> dict[str, str | None]: | |||
| return link_data | |||
|
|
|||
|
|
|||
| def parse_form(html: AnyStr, xpath: str = ".//form") -> dict[str, str | None]: | |||
| def parse_form(html: AnyStr, xpath: str = ".//form") -> dict: | |||
There was a problem hiding this comment.
Specify the value types in the return type annotation for clarity and type safety.
def parse_form(html: AnyStr, xpath: str = ".//form") -> dict[str, Optional[str]]:
moocfi_cses.py
Outdated
| if args.cmd == "submit": | ||
| html = session.http_request(urljoin(base_url, f"task/{args.task_id}")) | ||
| task = parse_task(html) | ||
| if not task.submit_file or task.submit_file == "N/A": | ||
| raise ValueError("No submission filename found") | ||
| if not task.submit_link or task.submit_link == "N/A": | ||
| raise ValueError("No submission link found") | ||
|
|
||
| submit_form_html = session.http_request(urljoin(base_url, task.submit_link)) | ||
| submit_form_data = parse_form(submit_form_html) | ||
| action = submit_form_data.pop("_action") | ||
|
|
||
| for key, value in submit_form_data.items(): | ||
| submit_form_data[key] = (None, value) | ||
| submit_form_data["file"] = (task.submit_file, open(task.submit_file, "rb")) | ||
| submit_form_data["lang"] = (None, "Python3") | ||
| submit_form_data["option"] = (None, "CPython3") | ||
|
|
||
| res = session.http_session.post( | ||
| urljoin(base_url, action), files=submit_form_data | ||
| ) | ||
| html = res.text | ||
| result_url = res.url | ||
| print("Waiting for test results.", end="") | ||
| while "Test report" not in html: | ||
| print(".", end="") | ||
| sleep(1) | ||
| html = session.http_request(result_url) | ||
|
|
||
| print() | ||
| root = htmlement.fromstring(html) | ||
| submit_status_element = root.find('.//td[.="Status:"]/..') or Element("td") | ||
| submit_status_span_element = submit_status_element.find("td/span") or Element( | ||
| "span" | ||
| ) | ||
| submit_status = submit_status_span_element.text or "" | ||
| submit_result_element = root.find('.//td[.="Result:"]/..') or Element("td") | ||
| submit_result_span_element = submit_result_element.find("td/span") or Element( | ||
| "span" | ||
| ) | ||
| submit_result = submit_result_span_element.text or "" | ||
|
|
||
| print(f"Submission status: {submit_status.lower()}") | ||
| print(f"Submission result: {submit_result.lower()}") | ||
|
|
There was a problem hiding this comment.
Consider refactoring the submission logic into a separate function for better readability and maintainability.
def submit_task(session, base_url, task_id, filename):
html = session.http_request(urljoin(base_url, f"task/{task_id}"))
task = parse_task(html)
if not task.submit_file or task.submit_file == "N/A":
raise ValueError("No submission filename found")
if not task.submit_link or task.submit_link == "N/A":
raise ValueError("No submission link found")
submit_form_html = session.http_request(urljoin(base_url, task.submit_link))
submit_form_data = parse_form(submit_form_html)
action = submit_form_data.pop("_action")
for key, value in submit_form_data.items():
submit_form_data[key] = (None, value)
submit_form_data["file"] = (task.submit_file, open(task.submit_file, "rb"))
submit_form_data["lang"] = (None, "Python3")
submit_form_data["option"] = (None, "CPython3")
res = session.http_session.post(
urljoin(base_url, action), files=submit_form_data
)
html = res.text
result_url = res.url
print("Waiting for test results.", end="")
while "Test report" not in html:
print(".", end="")
sleep(1)
html = session.http_request(result_url)
print()
root = htmlement.fromstring(html)
submit_status_element = root.find('.//td[.="Status:"]/..') or Element("td")
submit_status_span_element = submit_status_element.find("td/span") or Element("span")
submit_status = submit_status_span_element.text or ""
submit_result_element = root.find('.//td[.="Result:"]/..') or Element("td")
submit_result_span_element = submit_result_element.find("td/span") or Element("span")
submit_result = submit_result_span_element.text or ""
print(f"Submission status: {submit_status.lower()}")
print(f"Submission result: {submit_result.lower()}")
# In main function
if args.cmd == "submit":
submit_task(session, base_url, args.task_id, args.filename)
madeddie
force-pushed
the
27-implement-exercise-solution-submission-submit-subcommand
branch
from
3e38a5a
to
e555cc0
Compare
|
madeddie
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- tests/test_tyora.py (2 hunks)
- tyora.py (9 hunks)
Files skipped from review due to trivial changes (1)
- tests/test_tyora.py
Additional comments not posted (6)
tyora.py (6)
9-9: Import statement forsleeplooks good.
149-153: Subparser for submitting tasks looks good.
261-264: Addition ofsubmit_linkattribute inTaskclass looks good.
326-331: Changes toparse_taskfunction to extract and assignsubmit_linklook good.Also applies to: 350-350
362-368: Commenting out thesubmit_taskfunction is acceptable.
423-467: Changes to themainfunction to handle task submissions look good.
…mand' of github.com:madeddie/moocfi_cses into 27-implement-exercise-solution-submission-submit-subcommand
|
|
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tyora.py (10 hunks)
Additional comments not posted (7)
tyora.py (7)
9-9: Import ofsleepfrom thetimemodule is appropriate for the new submission functionality where delays are expected.
149-157: The addition of a new subparser for submitting exercise solutions is well-implemented. The arguments are clear and the help messages are informative.
264-267: The addition of optional attributes (description,code,submit_file,submit_link) to theTaskclass is a good use of Python'sOptionaltype hint to handle potentially missing data. This change enhances the flexibility of theTaskdata structure.
293-297: The logic to determine the task state based on the class attribute in the HTML element is clear and concise.
321-325: Proper error handling in theparse_taskfunction when task ID or name is missing. This will prevent the application from proceeding with incomplete data.
332-339: The extraction ofsubmit_linkfrom the HTML is crucial for the submission functionality. Ensure that the link is correctly parsed and handled in subsequent steps.
357-357: The construction of theTaskobject with all the newly added optional fields is correctly implemented.
| @@ -221,7 +231,7 @@ def find_link(html: AnyStr, xpath: str) -> dict[str, str | None]: | |||
| return link_data | |||
|
|
|||
|
|
|||
| def parse_form(html: AnyStr, xpath: str = ".//form") -> dict[str, str | None]: | |||
| def parse_form(html: AnyStr, xpath: str = ".//form") -> dict: | |||
There was a problem hiding this comment.
The modification in the parse_form function to remove type hints for return values aligns with the changes in other parts of the codebase. However, consider adding a more detailed docstring to explain the parameters and the return type more clearly.
def parse_form(html: AnyStr, xpath: str = ".//form") -> dict:
"""
Search for the first form in html and return a dictionary with action and all other found inputs.
Args:
html (AnyStr): HTML content as a string.
xpath (str): XPath query to locate the form.
Returns:
dict: Dictionary containing form action and inputs.
"""
# function body remains the same
tyora.py
Outdated
| if args.cmd == "submit": | ||
| html = session.http_request(urljoin(base_url, f"task/{args.task_id}")) | ||
| task = parse_task(html) | ||
| if not task.submit_file and not args.filename: | ||
| raise ValueError("No submission filename found") | ||
| if not task.submit_link: | ||
| raise ValueError("No submission link found") | ||
| submit_file = args.filename or task.submit_file or "" | ||
|
|
||
| submit_form_html = session.http_request(urljoin(base_url, task.submit_link)) | ||
| submit_form_data = parse_form(submit_form_html) | ||
| action = submit_form_data.pop("_action") | ||
|
|
||
| for key, value in submit_form_data.items(): | ||
| submit_form_data[key] = (None, value) | ||
| submit_form_data["file"] = (submit_file, open(submit_file, "rb")) | ||
| submit_form_data["lang"] = (None, "Python3") | ||
| submit_form_data["option"] = (None, "CPython3") | ||
|
|
||
| res = session.http_session.post( | ||
| urljoin(base_url, action), files=submit_form_data | ||
| ) | ||
| html = res.text | ||
| result_url = res.url | ||
| print("Waiting for test results.", end="") | ||
| while "Test report" not in html: | ||
| print(".", end="") | ||
| sleep(1) | ||
| html = session.http_request(result_url) | ||
|
|
||
| print() | ||
| root = htmlement.fromstring(html) | ||
| submit_status_element = root.find('.//td[.="Status:"]/..') or Element("td") | ||
| submit_status_span_element = submit_status_element.find("td/span") or Element( | ||
| "span" | ||
| ) | ||
| submit_status = submit_status_span_element.text or "" | ||
| submit_result_element = root.find('.//td[.="Result:"]/..') or Element("td") | ||
| submit_result_span_element = submit_result_element.find("td/span") or Element( | ||
| "span" | ||
| ) | ||
| submit_result = submit_result_span_element.text or "" | ||
|
|
||
| print(f"Submission status: {submit_status.lower()}") | ||
| print(f"Submission result: {submit_result.lower()}") | ||
|
|
There was a problem hiding this comment.
The submission logic integrated into the main function is complex and involves multiple steps, including form parsing, file submission, and status checking. Consider refactoring this into a separate function or class to improve maintainability and testability.
def submit_task(session: Session, task: Task, filename: str) -> None:
"""
Handles the submission of a task using the provided session and task details.
Args:
session (Session): The session object with login details and cookies.
task (Task): The task object containing submission details.
filename (str): The filename of the solution to submit.
"""
# Move the submission logic here
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tyora.py (10 hunks)
Additional comments not posted (9)
tyora.py (9)
9-9: Added import ofsleepfrom thetimemodule.This import is necessary for the new submission logic which includes a delay loop.
149-156: Added a new subparser for submitting exercise solutions.This change aligns with the PR's objective to implement a submit action. The arguments and help texts are clear and appropriate.
234-234: Modification toparse_formfunction to remove type hints for return values.The previous review comment suggested adding a detailed docstring, which has been implemented. This enhances clarity and maintainability.
264-267: UpdatedTaskclass to include optional attributes.The addition of
submit_linkand making other attributes optional supports the new functionality for task submission and aligns with the changes in the system's requirements.
293-297: Logic to determine task state based on class attributes in HTML.This implementation is efficient and clear, using conditional expressions to set the task state.
321-325: Error handling inparse_taskfunction.Proper error handling for missing task ID and name ensures robustness and user-friendly error messages.
332-338: Extraction ofsubmit_linkfrom HTML inparse_task.This is crucial for the submission process, ensuring that the link is dynamically retrieved from the task details.
369-374: Commented outsubmit_taskfunction.As per the PR description, the submission logic has been moved to the
mainfunction. This centralizes the submission logic, potentially simplifying maintenance.
453-487: Integrated submission logic into themainfunction.This integration is complex but necessary for the new functionality. However, consider refactoring this into a separate function or class to improve maintainability and testability, as previously suggested.
madeddie
deleted the
27-implement-exercise-solution-submission-submit-subcommand
branch
implements: #27
Needs quite some refactoring, but it's functional.
Needs tests too.
Summary by CodeRabbit
New Features
submitcommand for submitting tasks with options to specify filename and task ID.Enhancements
Refactor