-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat remake #6
Open
danielholmstrom
wants to merge
19
commits into
madepeople:feat_remake
Choose a base branch
from
danielholmstrom:feat_remake
base: feat_remake
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat remake #6
danielholmstrom
wants to merge
19
commits into
madepeople:feat_remake
from
danielholmstrom:feat_remake
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An invoice can not be used for a specific country unless the configuration is correct.
Testing is done in a minimal checkout that emulates a single-page checkout.
The fields should still be visible even if their value cannot be changed.
* Added individual helpers for setting up different checkouts. * Added test that runs on onepagecheckout
The disabled/not disabled tests will run on so many inputs that they can have single implementations.
The inputs should be readonly, not disabled.
* Support for toggling/hiding use_for_shipping_yes * svea-hidden class is tested instead of readonly
The div is not only used for when country is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.