System.Configuration: User configuration file saving fixes, part 1. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the sqlConnectionRetryInterval property. Native uses the default validator for this property, this Was likely added as a copy pasting mistake from stateNetworkTimeoutProp. Mono doesn't validate property values so this never got caught. Signed-off-by: Connor McAdams <[email protected]>
Signed-off-by: Connor McAdams <[email protected]>
…tion with referencesource. Signed-off-by: Connor McAdams <[email protected]>
…implementation with referencesource. Signed-off-by: Connor McAdams <[email protected]>
…alizeElement/SerializeToXmlElement. This allows us to check whether or not a ConfigurationElement has any data to serialize without using SaveContext:HasValues, which brings us closer to referencesource. Signed-off-by: Connor McAdams <[email protected]>
…rce to store ConfigurationElement values. This patch replaces Mono's method of storing ConfigurationElement values with the method from referencesource, which is a prerequisite for porting over a few other methods that we need. Signed-off-by: Connor McAdams <[email protected]>
madewokherd
added a commit
to wine-mono/wine-mono
that referenced
this pull request
Jan 26, 2024
|
Merged manually as 2cf7a02 and wine-mono/wine-mono@053ff18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains half of the patches necessary to fix the issues in the
configuration-with-defaultstest, I've tried to split things to make them easier for review. The final patch in this series was difficult to split, so it's a bit big.The full series of patches is here for reference.
This series also fixes the standalone configuration test t12.