Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added PEP files to separate /tools/ subdirectory #617

Closed
wants to merge 32 commits into from

Conversation

zeniheisser
Copy link
Contributor

Added the two libraries I've been working on for the reweighting project to a distinct subdirectory of .../tools/, called /tools/PEP/. Currently just includes the LHE parser (PEP) and the reweighting lib (PEPPER), both WIP

@valassi valassi marked this pull request as draft March 30, 2023 10:36
@valassi
Copy link
Member

valassi commented Mar 30, 2023

Hi @zeniheisser thanks. Do I understand correctly that this PR #617 replaces #612?

By the way, the GPU CI fails, but it has nothing to do with this specific PR. I think that it is an infrastructure issue (@hageboeck maybe you can have a look please? thanks)

@zeniheisser
Copy link
Contributor Author

@valassi yes, there was a preamble in the previous one I forgot to remove which should not have been there. If you want to take a look, this is the rq to look at!

@hageboeck
Copy link
Member

Hi @zeniheisser thanks. Do I understand correctly that this PR #617 replaces #612?

By the way, the GPU CI fails, but it has nothing to do with this specific PR. I think that it is an infrastructure issue (@hageboeck maybe you can have a look please? thanks)

The cuda path changed, so it doesn't find it. I will add /usr/local/cuda/ to PATH now, reboot in 1 minute

@hageboeck
Copy link
Member

hageboeck commented Mar 30, 2023

The cuda path changed, so it doesn't find it. I will add /usr/local/cuda/ to PATH now, reboot in 1 minute

The CI machine now correctly sets its own PATH when you log in, but in your branch, /usr/local/cuda-12 is still hardcoded in the CI workflow file.
You have to rebase for the change to take effect.

See here:

CUDA_HOME: /usr/local/cuda/

zeniheisser and others added 24 commits March 30, 2023 15:06
Move CUDA_HOME to /usr/local/cuda in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants