Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small additions #142

Merged
merged 9 commits into from
Mar 30, 2024
Merged

Small additions #142

merged 9 commits into from
Mar 30, 2024

Conversation

brekk
Copy link
Contributor

@brekk brekk commented Mar 27, 2024 •
edited
Loading

  • Moved Function.any and Function.all to List instead
  • Added Function.unless, which is the complement to Function.when
  • Added List.cut which allows for segmenting a given list
  • Added Tuple.mapFst / Tuple.mapSnd for easy manipulation of binary Tuples (nixed for now, hoping to leverage Bifunctor later on)
  • Removed memoization implementation from Function

@brekk brekk changed the title Function.unless / List.any / List.all Function.unless / List.cut / List.any / List.all Mar 27, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (c7b85b0) to head (cff272c).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files          81       81           
  Lines       11858    11858           
=======================================
  Hits         8791     8791           
  Misses       3067     3067

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brekk brekk changed the title Function.unless / List.cut / List.any / List.all Function.unless / List.cut / List.any / List.all / Tuple.mapFst / Tuple.mapSnd Mar 28, 2024
@brekk brekk changed the title Function.unless / List.cut / List.any / List.all / Tuple.mapFst / Tuple.mapSnd Small additions Mar 28, 2024
@brekk brekk requested a review from aboeglin March 28, 2024 20:21
aboeglin
aboeglin approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@aboeglin aboeglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aboeglin aboeglin merged commit 1df2d8e into master Mar 30, 2024
4 checks passed
@aboeglin aboeglin deleted the unless-any-all branch March 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboeglin aboeglin aboeglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brekk @aboeglin