Add export for dataSubscriptionRequest #1
Conversation
|
|
||
| request = (endpoint, updatedCallback) => { | ||
| const subscription = this.createSubscription(endpoint); | ||
| subscription.run(); |
There was a problem hiding this comment.
I think this should run after the below listener is attached.
| @@ -49,6 +49,15 @@ class Store { | |||
| dump = () => { | |||
| return cloneDeep(this._store); | |||
| } | |||
|
|
|||
| request = (endpoint, updatedCallback) => { | |||
There was a problem hiding this comment.
In order to be consistent with regular subscriptions and to provide more flexibility it should take and pass paramsFunc to the subscription. Or it should take params and pass () => params if it's a one time call.
|
Thank you @mikeperri, the feature is useful, but I see one issue here - memory leak. The created subscription never gets cleaned up by GC because it has an event listener attached to it. Every time |
Explained in the README. Also fixes a bug where EMPTY_FUNC actually returns undefined instead of empty object.