Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP Tools for VS #116

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Miloslav
Copy link
Contributor

@Miloslav Miloslav commented Sep 5, 2024

No description provided.

@madskristensen madskristensen merged commit ae690c5 into madskristensen:master Sep 5, 2024
2 checks passed
@madskristensen
Copy link
Owner

Nice, thank you @Miloslav

@Miloslav
Copy link
Contributor Author

Miloslav commented Sep 6, 2024

Thank you, @madskristensen !

May I ask if the built-in brace colorization in VS2022 is based on this extension? If not, could you please provide any guidance on how to extend it or whom to contact? I would like to ensure that it also supports PHP, if possible.

@lordfanger
Copy link
Contributor

It was not based on. But was only a sign, that full VS developers would like to have that functionality. If you want to extend the built-in functionality you have to use https://developercommunity.visualstudio.com/VisualStudio

I keep using this extension because it is more capable, extensible and have vertical color lines ^^

@madskristensen
Copy link
Owner

@olegtk might know

@olegtk
Copy link

olegtk commented Sep 6, 2024

No, built-in brace colorization in VS2022 is not based on this extension. We rely on language services to provide IBracePairTag instead, here is Roslyn implementation as a sample: https://github.com/dotnet/roslyn/blob/main/src/EditorFeatures/Core/BracePairs/BracePairsTaggerProvider.cs

Or if you are using LSP and language configuration rules you can just specify rules for bracket pairs.

@Miloslav
Copy link
Contributor Author

Thank you so much, just what we needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants