[MNOE-1037]on company view page - tab lost on refresh #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuritomanek
reviewed
May 29, 2018
| vm.initialize = -> | ||
| vm.isLoading = false | ||
| if vm.isBillingShown() | ||
| vm.activeTab = 'billing' |
There was a problem hiding this comment.
@jin521
Can this be moved into the setActiveTab() method to keep the logic all together?
BrunoChauvet
approved these changes
May 31, 2018
ouranos
requested changes
May 31, 2018
Contributor
ouranos
left a comment
ouranos
left a comment
There was a problem hiding this comment.
I think it would make more sense to leverage the ui-router rather than parsing the state and setting the tab based on that.
You could either use:
Or do a bit more research on what's possible.
This link could be interesting to read to.
Also you only did this for 2 tabs out of the 4.
| vm.activeTab = 'billing' | ||
| else | ||
| vm.activeTab = 'members' | ||
| #On refreshing the page it should stay on the same tab |
Contributor
There was a problem hiding this comment.
Use one space between the leading # character of the comment and the text of the comment.
| vm.initialize = -> | ||
| vm.isLoading = false | ||
| if vm.isBillingShown() | ||
| vm.activeTab = 'billing' |
| #==================================== | ||
| # Tab Management | ||
| #==================================== | ||
| setActiveTab = () -> |
Contributor
There was a problem hiding this comment.
This should be made generic as there can be more tabs depending on settings and permission: billing, team, members, settings
added 9 commits
June 1, 2018 16:47
…o MNOE-1037-tab-lost-on-refresh
…o MNOE-1037-tab-lost-on-refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.