Skip to content

Conversation

@zohaibahmeds63
Copy link

@zohaibahmeds63 zohaibahmeds63 commented Aug 13, 2018

  • Update role in teams for team member in service MnoeTeams after role has been successfully updated on Members tab in Company screen.

@ouranos ouranos requested review from adamaziz15 and ouranos August 20, 2018 23:06
@ouranos ouranos added the bug label Aug 20, 2018
@ouranos
Copy link
Contributor

ouranos commented Aug 20, 2018

@zohaibahmeds63 could you rebase to solve conflicts? Thanks

@ouranos
Copy link
Contributor

ouranos commented Aug 22, 2018

Rebased to solve conflict

Copy link
Contributor

@ouranos ouranos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamaziz15 what do you think?

The logic is stating to get quite complicated:

        updateNbOfSuperAdmin()
        # Update user role
        if obj.email == MnoeCurrentUser.user.email
          $scope.user_role = obj.role
          rolesToDisplay()
          clearInstancesCache()
          reloadCurrentOrganization()
        MnoeTeams.updateTeamMemberRole(obj)
        self.close()

Copy link
Contributor

@adamaziz15 adamaziz15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ouranos I agree, it's already gotten a bit complex before this.

I'm not sure how to fix this role issue though, do you think it would be better to simplify this a bit and trigger a refresh instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants