feat(event): implement preview with drafts #1739
Conversation
This reverts commit 2e92642.
dargmuesli
force-pushed
the
master
branch
2 times, most recently
from
db8592b to
95ec293
Compare
| @@ -24,6 +24,7 @@ | |||
| "test:e2e:docker:server:static": "pnpm --dir tests run test:e2e:docker:server:static" | |||
| }, | |||
| "devDependencies": { | |||
| "@internationalized/date": "^3.6.0", | |||
There was a problem hiding this comment.
This should go to src/package.json and have no caret
| "type": "module" | ||
| "type": "module", | ||
| "dependencies": { | ||
| "@opentelemetry/resources": "^1.30.1" |
There was a problem hiding this comment.
I don't think we need to commit this. Issues related to this should likely be fixed by other means.
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { ref, watch } from 'vue' |
There was a problem hiding this comment.
This line is auto-imported and can be removed
| defineProps<{ | ||
| modelValue: CalendarDate | ||
| placeholder?: string | ||
| timePlaceholder?: string | ||
| initialTime?: string | ||
| }>(), |
There was a problem hiding this comment.
Please extract this type definition into a Props interface in case we need to import it in another file
| placeholder: 'Select date', | ||
| timePlaceholder: 'Select time', |
There was a problem hiding this comment.
Those strings should be translatable
| preview: Vorschau des Ereignisses | ||
| previewHeading: Ereignisvorschau |
There was a problem hiding this comment.
| preview: Vorschau des Ereignisses | |
| previewHeading: Ereignisvorschau | |
| preview: Vorschau der Veranstaltung | |
| previewHeading: Veranstaltungsvorschau |
| @@ -13,6 +13,7 @@ | |||
| <LayoutBreadcrumbs :items="breadcrumbItems" /> | |||
| <section> | |||
| <LayoutPageTitle :title="t('title')" /> | |||
|
|
|||
| statusCode: 404, | ||
| }) | ||
| // return abortNavigation({ statusCode: 404 }) | ||
| if (!nuxtApp.isHydrating) { |
There was a problem hiding this comment.
Isn't isHydrating only true while for a few milliseconds after page load? Maybe you can explain this logic to me in person
src/gql/generated/graphcache.ts
Outdated
There was a problem hiding this comment.
Merging in master should reduce the diff here
| @@ -138,7 +138,8 @@ | |||
| "vue-router": "4.5.0", | |||
| "vue-tsc": "2.2.0", | |||
| "workbox-precaching": "7.3.0", | |||
| "zod": "3.24.1" | |||
| "zod": "3.24.1", | |||
| "@internationalized/date": "^3.6.0" | |||
There was a problem hiding this comment.
| "@internationalized/date": "^3.6.0" | |
| "@internationalized/date": "3.6.0" |
and likely will be moved further up by installing it through pnpm
dargmuesli
changed the title
📚 Description
This PR
📝 Checklist