Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make a demo of dynamic services #139

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Sep 18, 2023

This is a demo of an idea I had while reviewing code from @gowrizrh @danslo and @vpodorozh as well as @jissereitsma and @sprankhub in the context of #97 and #14 as well https://github.com/mage-os/infrastructure/blob/main/.github/workflows/unit-tests.yml

You can see in my fork that this actually works!

I really really really hate the duplication of:

  1. The same command
  2. The services chunk

that we all have across various actions. For the "same command" that's just maintenance. For the services, I always thought that is just "how it is" and that we have to deal with it, however, it doesn't have to be, as I've just discovered.

We can leverage the same ideas I did with supported-versions to encapsulate all that services logic setup logic.

This doesn't use warden but perhaps we could work with the @navarr to come up with something similar?

@damienwebdev damienwebdev changed the title chore: make a demo of actions chore: make a demo of dynamic services Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant