Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unit tests: Install specific PHP version for composer (#44) #45

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

rhoerr
Copy link
Contributor

@rhoerr rhoerr commented Jul 8, 2024

See #44 -- current unit-tests action uses Ubuntu default PHP (8.1), which is a problem as Magento now requires 8.2+ for latest. Adding setup-php should fix this.

Reference https://github.com/shivammathur/setup-php/tree/v2/

@rhoerr rhoerr requested a review from a team as a code owner July 8, 2024 19:15
@rhoerr rhoerr added the bug Something isn't working label Jul 8, 2024
@mage-os-ci mage-os-ci merged commit c2fe222 into mage-os:main Jul 8, 2024
1 check passed
@rhoerr rhoerr deleted the unit-tests/setup-php-version branch July 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants