feat: switch github-actions repo code owners to infra team #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem correct. I believe we tried this once before. https://github.com/mage-os/github-actions/blob/main/.github/CODEOWNERS @sprankhub |
|
Is it a relic from the original repo? |
DavidLambauer
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
I personally believe that @damienwebdev enjoys being CODEOWNER for EVERYTHING so that I wouldn't change that 🤣 However, it makes sense to fix the team prop here
|
If I remember correctly, Sprankhub had some kind of conflict with archived repos and CODEOWNERS. I don't remember exactly why but it was preventing management of this. |
|
Yeh, I thought we just wanted to drop it from the tf state by hand. 😈 Not sure if we were brave enough... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So @damienwebdev isn't always set as a reviewer by default.