Add mono repo push allowances, fixes #85 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/plan |
|
@sprankhub Starting Terraform plan https://github.com/mage-os/terraform/actions/runs/9439249204 |
Terraform Plan
|
damienwebdev
requested changes
Jun 12, 2024
variables.tf
Outdated
| description = "This module provides events integrations to AWS." | ||
| teams = ["distribution", "async-events"] | ||
| topics = ["mage-os", "magento", "ecommerce", "magento2", "adobecommerce", "aws"] | ||
| mono_repository = true |
There was a problem hiding this comment.
Does this flag mean that it's part of a mono repo? Or that it's a mono repo itself? Can you disambiguate the flag?
There was a problem hiding this comment.
It means that it is part of a mono repo. Do you have an idea for a better name? I currently cannot think of any.
There was a problem hiding this comment.
PartOfMonorepo
InMonorepo
MonorepoComponent
There was a problem hiding this comment.
Maybe one of these?
is_part_of_monorepobelongs_to_monorepomonorepo_partsplit_monorepo_partmonorepo_slice
There was a problem hiding this comment.
monorepo_partmonorepo_componentis_part_of_monorepobelongs_to_monorepo
are my favorite.
damienwebdev
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.