[DFT] Implement Push the Limit #13408
Conversation
|
|
||
| class PushTheLimitSacrificeEffect extends OneShotEffect { | ||
|
|
||
| private final Set<Card> cards; |
There was a problem hiding this comment.
Instead of storing the card objects directly, store MageObjectReferences to them. That way it won't sacrifice a permanent that you've revived and then blinked.
| } | ||
| } | ||
|
|
||
| class PushTheLimitEffect extends ReturnFromYourGraveyardToBattlefieldAllEffect { |
There was a problem hiding this comment.
No need to extends. There aren’t super.apply calls (e.g. whole logic is new), so it’s useless here.
| Zone.BATTLEFIELD, source, game, false, false, false, null); | ||
| if (result) { | ||
|
|
||
| Effect sacrificeEffect = new PushTheLimitSacrificeEffect(cards); |
There was a problem hiding this comment.
No needs in custom sacrifice trigger, add directly to permanents. See Push Pull as example:
There was a problem hiding this comment.
That incorrectly produces a separate trigger for each creature. I think it'd be best to use a SacrificeAllControllerEffect filtered with a MageObjectReferencePredicate.
There was a problem hiding this comment.
Good point. It must generate 1 trigger due rules. So Push // Pull is wrongly implemented (related issue #13450)
There was a problem hiding this comment.
Alternative implementation by SacraficeTargetEffect and fixed targets list:
For #13033
This card refactors a common effect for animating Vehicles and has a custom return from your graveyard effect with delayed sacrifice.