-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSK] Implement Osseous Sticktwister #13421
base: master
Are you sure you want to change the base?
Conversation
would be common in gameplay.
OsseousSticktwisterEffect() { | ||
super(Outcome.Benefit); | ||
this.staticText = "each opponent may sacrifice a nonland permanent or discard a card. Then {this} " | ||
+ "deals damage equal to it's power to each opponent who didn't sacrifice a permanent or discard a card in this way."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"its" not "it's" power
} | ||
} | ||
// They either can't discard or sacrifice or chose not to. | ||
opponent.damage(dmg.getValue(), source.getSourceId(), source, game); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct, as all damage must be dealt simultaneously at the end. Need to store it (probably a map of UUID to Integer), processAction after the loop, then foreach on the stored values
boolean canPay = cost.canPay(source, source, id, game); | ||
|
||
if (canPay) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style, no newline before opening brace
Also added some unit tests to test common cases that could occur during gameplay.