[WHO] Implement The Second Doctor #13435
Open
+154
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Mar 15, 2025
| Player player = game.getPlayer(playerId); | ||
| if (player != null) { | ||
| if (player.chooseUse(Outcome.DrawCard, "Draw a card ?", source, game)) { | ||
| player.drawCards(1, source, game); |
There was a problem hiding this comment.
need to check for prevention/replacement right? drawCards returns an int, only add restriction effect if > 0
(then could combine these four conditions into a single if statement)
| @Override | ||
| public boolean apply(Game game, Ability source) { | ||
| Player controller = game.getPlayer(source.getControllerId()); | ||
| if (controller != null) { |
There was a problem hiding this comment.
just a style thing, but it's easier to read with less nesting, e.g.
if (controller == null) {
return false;
}
// then continue code path here for non null case| } | ||
| } | ||
|
|
||
| class TheSecondDoctorCantAttackEffect extends RestrictionEffect { |
There was a problem hiding this comment.
did you base this class off of existing code?
|
|
||
| @Override | ||
| public boolean isInactive(Ability source, Game game) { | ||
| return game.getTurnPhaseType() == TurnPhase.END && this.isYourNextTurn(game); |
There was a problem hiding this comment.
are you sure this is correct? what if the affected player takes an extra turn?
| } | ||
| // defender is a permanent | ||
| if (game.getPermanent(defenderId) != null) { | ||
| return !game.getPermanent(defenderId).getControllerId().equals(controllerId); |
There was a problem hiding this comment.
better to declare a permanent and null check it to ensure you're getting the same object
also can simplify with '.isControlledBy()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10653 .
Implement [[The Second Doctor]].
Card was tested and seems to work fine.