-
Notifications
You must be signed in to change notification settings - Fork 165
Release
Marc Ginesta edited this page Oct 5, 2022
·
14 revisions
In order to avoid broken builds in the Magento ecosystem and major issues, we would like to check the magento-coding-standard against magento2ce and magento2ee prior to the release.
The following instructions work for both magento2ce and magento2ee.
First of all, you'll need to get the latest changes from develop branch git pull origin 2.4-develop
([email protected]:magento-commerce/magento2*e.git).
Then, you'll need to update the composer.json file as follows:
{
...
"require-dev": {
...
"magento/magento-coding-standard": "dev-[branch]"
...
}
...
"minimum-stability": "dev",
"repositories": [
{
"type": "git",
"url": "https://github.com/[fork]/magento-coding-standard"
}
]
}
Notes:
-
fork: your own fork ormagentoif you have already merged your changes -
branch: in case changes are not merged it will be your development branch, otherwisedevelop
Now, you need to follow these steps:
- Open a PR (for both repos) and run tests using
@magento run all tests(write it as a comment on themagento2cePR) - If static tests fail 🔴 , then you need to perform changes in your code and you should not merge changes to
masterbranch - If tests all tests are green 🟢 (specifically, we need Static tests to be green) you can proceed with the release
- Open a PR for
magento-coding-standardrepo and merge your branch todevelopif you haven't done this already - Create a new branch from
develop(i.e.,release-vN) - Increment the version in
composer.json - Run
composer updateto update thecomposer.lock - Open a PR on
magento-commerce/magento-coding-standardand merge it todevelopbranch - Merge
developbranch tomasterbranch creating a new PR onmagento-commerce/magento-coding-standard - Create a new release on Github
- Ensure the new version is available in packagist
- 📢 Notify the #coding-standard channel (from the Magento Open Source workspace)
- Update
composer.lockformagento-commerce/magento2ceandmagento-commerce/magento2eerunningcomposer update magento/magento-coding-standard - Open a PR (for both repos) and run tests
@magento run all tests - ☑️ Make sure that all tests are green 🟢 (they should be green since you did not perform further changes)
- You'll need to update
composer.jsonfor other repos such asmagento-api-index,mrayanduct. We needmagento-coding-standardpointing to the newest release. - Update
composer.lockfor each repo you required by runningcomposer update magento/magento-coding-standard - Open a PR for each repo you have updated and merge changes to develop