Fix incompatibility with laminas-escaper (2.7.1)

[tufahu]

Description

laminas/laminas-escaper 2.7.1 use strict types and it breaks magento framework escaper

Fixed Issues

1. Fixes Latest laminas/laminas-escaper (2.7.0 -> 2.7.1) breaks product and catalog category view pages #33346

[m2-assistant]

Hi @tufahu. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

Hi @tufahu,
Could you cover your changes with unit test?

[thomas-kl1]

@ihor-sviziev is it a kind of joke?

[ihor-sviziev]

@thomas-kl1, no, it's not. We definitely have a new case that isn't covered with any type of test. That's why we're having this issue.
I think it would be effortless to cover it with a unit test.

[hostep]

This is a super important fix, this needs to be turned into a hotfix ASAP in my opinion, maybe it's worth adding this to Magento's quality patches repo as well.

All Magento versions that have this laminas/laminas-escaper package (being: Magento 2.3.5 and higher) will crash when they upgrade to version 2.7.1 of this package.

Thanks @tufahu !

[thomas-kl1]

That's why we're having this issue.
I think it would be effortless to cover it with a unit test.

@ihor-sviziev maybe as a maintainer you could push for strict and proper type signatures in method. Such unit tests doesn't belongs there when it's well typed..

[ihor-sviziev]

Based on discussion with @sivaschenko (more detils see in magento/magento-semver#63 (comment)) - we should revert the adding strict types, as it will break backward compatibility for the cases when in the client code we have declared strict_types=1, but for some reason, using a different type.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B, Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[m2-assistant]

Hi @tufahu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[mrtuvn]

Hi any queue or plan to sync this to mainline 2.4-develop
cc @sivaschenko @gabrieldagama