No update must be a boolean, int given for bin/magent sampledata:deploy|remove --no-update

[JeroenBoersma]

Description (*)

When adding or removing sample data you can tell the composer update command to not invoke the update command right away. Since newer versions type checking is set for this argument and it must be of type boolean instead of a integer.

Fixed Issues (if relevant)

1. Fixes bin/magento sampledata:deploy --no-update throws an exception #39344

Manual testing scenarios (*)

1. Install a clean Magento 2 installation
2. Try to deploy sample data without directly updating --no-update
3. A error was thrown, not anymore

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @JeroenBoersma. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[JeroenBoersma]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @JeroenBoersma,

Thanks for the collaboration!

The changes seems good to us but please fix the failed static test failures, the other failures seems flaky to me.

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @JeroenBoersma,

Thanks for the collaboration!

The changes seems good to us but please fix the failed static test failures, the other failures seems flaky to me.

Thanks

I have fixed the failed static tests. Moving it to "Pending Review".

cc: @JeroenBoersma

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @JeroenBoersma,

Thanks for the collaboration & contribution!

✔️ QA Passed

Manual testing scenarios

• Install a clean Magento 2 installation
• Try to deploy sample data without directly updating --no-update

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Dash]

@magento run Unit Tests

[engcom-Dash]

We got a green build, so I’m moving this to "Merge in Progress."