Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deleting options from the duplicated bundle #39414

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

codingkoaladev
Copy link
Contributor

@codingkoaladev codingkoaladev commented Nov 29, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Duplication of bundle product removes bundle selection from original product #38990

Manual testing scenarios (*)

  1. Create 2 simple products A and B
  2. Create 1 Bundle product B1, and assign Simple A and B as the bundle options
  3. Save and clone B1
  4. B1C will be created

Before the fix:
B1 has no bundle options
B1C has taken over bundle options of B1

After the fix:
B1 has bundle options unchanged
B1C has its own bundle options created

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

When you save cloned bundle options, the options get deleted from the original record. In catalog_product_bundle_selection table the existing record for the original parent_product_id gets overwritten by the duplicated parent_product_id
Copy link

m2-assistant bot commented Nov 29, 2024

Hi @codingkoaladev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication of bundle product removes bundle selection from original product
1 participant