Skip to content

Unexisting sitemap responds with product image #40135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

Unexisting sitemap responds with product image #40135

wants to merge 6 commits into from
+3 −3

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Aug 12, 2025

Description (*)

Limit file types fallback to default product image in pub/media

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Unexisting sitemap responds with product image #39756

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 12, 2025

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rogerdz
Copy link
Contributor Author

rogerdz commented Aug 12, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Aug 12, 2025
lbajsarowicz
lbajsarowicz suggested changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Definitely no-go

You are literally falling back CSV and XML, just like the original code.

  • Your changes affect only Apache, without being handled correctly for Nginx.

@rogerdz
Copy link
Contributor Author

rogerdz commented Aug 14, 2025 •
edited
Loading

Hi @lbajsarowicz,
Oh, I only tested with /media/sitemap/foobarbaz, other cases like /media/sitemap/sitemap.xml or /media/sitemap/sitemap.csv should also return 404 when the file does not exist.
I have updated the code, thanks for the review

@rogerdz
Copy link
Contributor Author

rogerdz commented Aug 14, 2025

@magento run all tests

@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Sep 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review September 16, 2025 06:40
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Sep 16, 2025
engcom-Hotel
engcom-Hotel requested changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rogerdz,

Thanks for the contribution!

It seems the fix is still not correctly implemented for nginx users for the below reasons:

  • Sites relying on get.php fallback for dynamic content generation in /media/will break
  • nginx deployments will have different behavior than Apache deployments

Suggestion
Can we use conditional try_files for nginx users.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Sep 16, 2025
@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

We are still waiting for your inputs for the above review comment.

Thank you

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 7, 2025

Hi @engcom-Hotel,

How do you test ?

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

I haven’t tested it yet, I have just reviewed it for now and it seems that it is not correctly implemented for nginx users yet. Please let me know if I missed anything.

Thank you

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 7, 2025 •
edited
Loading

Hi @engcom-Hotel,
I tested again with nginx.

  • with product image still generate cache image normally
  • with non-existent image still return placeholder image
  • with non-existent file return 404 instead of placeholder image

maybe I missed something?

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Static Tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Hotel engcom-Hotel moved this from Changes Requested to Review in Progress in Community Dashboard Oct 9, 2025
engcom-Hotel
engcom-Hotel approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed functional tests seems flaky to me. Approving this PR.

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Oct 9, 2025
@engcom-Bravo engcom-Bravo self-assigned this Oct 10, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Testing to Testing in Progress in Community Dashboard Oct 10, 2025
@engcom-Bravo
Copy link
Contributor

Hi @rogerdz,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenarios

  • Install vanilla magento
  • open /media/sitemap/foobarbaz

Before: ✖️
Screenshot 2025-10-10 at 12 38 57 pm

After: ✔️

Screenshot 2025-10-10 at 1 02 37 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Oct 10, 2025
@engcom-Dash engcom-Dash self-assigned this Oct 10, 2025
@engcom-Dash
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 13, 2025 •
edited
Loading

The consistent failures in Functional CE, EE, and B2B are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

CE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento-commerce/magento2ce/pull/10125/abe193b8477734c8d0aea2c314716580/Functional/allure-report-ce/index.html#suites/e15534ee4f8cbddfff1336278d8204be
image

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40135/6e10c54eca09277f7910464ed2bd930a/Functional/allure-report-ce/index.html#categories/bdbf199525818fae7a8651db9eafe741
image

Known Issue
StorefrontGuestCreateOrderWithBundleProductCustomStockTest ACP2E-4260

EE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento-commerce/magento2ce/pull/10125/8fbdcfe9dbd507cf87402ccc4e084034/Functional/allure-report-ee/index.html
image
Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40135/5ab940151131e4ef0f6eea071a261bd1/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741
image

Known Issue
StorefrontGuestCreateOrderWithBundleProductCustomStockTest ACP2E-4260

B2B
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40135/a99166c94db1585ec889cda06334ab11/Functional/allure-report-b2b/index.html
image

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40135/738c7c41736014345ef37d7800877444/Functional/allure-report-b2b/index.html
image
Known Issue
StorefrontGuestCreateOrderWithBundleProductCustomStockTest ACP2E-4260

Hence, Moving this PR to Merge In Progress

@engcom-Dash engcom-Dash reopened this Oct 13, 2025
@engcom-Dash engcom-Dash moved this to Merge in Progress in Community Dashboard Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

+1 more reviewer

@lbajsarowicz lbajsarowicz lbajsarowicz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@engcom-Bravo engcom-Bravo

@engcom-Dash engcom-Dash

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: testing in progress Project: Community Picked PRs upvoted by the community

Projects

Community Dashboard
Status: Merge in Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexisting sitemap responds with product image

6 participants

@rogerdz @engcom-Hotel @engcom-Bravo @engcom-Dash @lbajsarowicz @engcom-Charlie