Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and alert on HTTP errors #168

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Oct 27, 2022

Fixes #71
Closes #143


Before (~32.5 seconds):

ℹ Collecting bundle modules in the browser.
ℹ Collecting modules for bundle "cms".

 ERROR  waiting for function failed: timeout 30000ms exceeded

  at new WaitTask (node_modules/puppeteer/lib/DOMWorld.js:549:28)
  at DOMWorld.waitForFunction (node_modules/puppeteer/lib/DOMWorld.js:454:12)
  at Frame.waitForFunction (node_modules/puppeteer/lib/FrameManager.js:657:28)
  at Page.waitForFunction (node_modules/puppeteer/lib/Page.js:1141:29)
  at module.exports (lib/generate/collectModules.js:10:16)
  at Object.cms (lib/generate/collector/cms.js:38:39)
  at processTicksAndRejections (internal/process/task_queues.js:97:5)
  at async module.exports (lib/generate.js:28:13)

After (~2.5 seconds):

ℹ Collecting bundle modules in the browser.
ℹ Collecting modules for bundle "cms".
ℹ Requested http://example.com/ but navigation ended on https://www.example.com/

 ERROR  HTTP status code 503 returned from https://www.example.com/

  at module.exports (lib/generate/createPage.js:36:19)
  at processTicksAndRejections (internal/process/task_queues.js:97:5)
  at async Object.cms (lib/generate/collector/cms.js:29:18)
  at async module.exports (lib/generate.js:28:13)

@fredden
Copy link
Contributor Author

fredden commented Oct 5, 2023

@krzksz is there anything I can do to help get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Error early during magepack generate if a URL returns 404
1 participant